Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration build issues esm #535

Conversation

drewbrokke
Copy link
Collaborator

Description

Continuing work on #492

This pull converts the project to ESM. This is only necessary because the new versions of certain dependencies require an ESM project, in this case update-notifier.

As noted in the message of the first commit (91d92b9 at the time of this writing), I followed the process detailed here: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c.

More specifically, I tracked with these headers:

It was a super helpful guide and I learned a lot in the process. It's worth looking over and reading the linked articles whenever you have a chance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have read the CONTRIBUTING document.
  • My commits follow the commitizen commit convention
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@drewbrokke drewbrokke mentioned this pull request Jul 13, 2023
8 tasks
@jwu910
Copy link
Owner

jwu910 commented Jul 13, 2023

Thanks drew! initial testing looks great 🥲

@jwu910 jwu910 merged commit 3c4e6a4 into jwu910:typescript-migration Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants