Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate package version to static values updated via npm script in publish cycle #538

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

jwu910
Copy link
Owner

@jwu910 jwu910 commented Jul 13, 2023

Description

I think this can work, need to see if/when/how we will update the source code just to be up to date with the tags, but i feel like shipping the version.ts during prebuild is going to be fine

Fixes #537

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have read the CONTRIBUTING document.
  • My commits follow the commitizen commit convention
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jwu910 jwu910 requested a review from kienD as a code owner July 13, 2023 17:44
@jwu910 jwu910 requested a review from drewbrokke July 13, 2023 17:44
@jwu910 jwu910 merged commit c931832 into main Jul 13, 2023
4 checks passed
@jwu910 jwu910 deleted the CIO-0-packageInfo branch July 13, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New published package broken
1 participant