fs.readFile() does not handle exceptions properly with extensions

[gcampax]

If a fs extension (such as the one introduced by jxcore-android/jxcore-cordova) throws an exception in readfilesync, mostly likely NOENT, readFile() crashes instead of calling the callback with the exception, which lets the caller handle it.

[obastemur]

/cc @ktrzeciaknubisa (high priority)

[ktrzeciaknubisa]

Personally I'm aware of this and I was even warning about this before. In fact, as far as we talk about jxcore-cordova, this was even fixed by commit and then reverted back. Here is some discussion.

But I believe this is dependent on how the extension method itself is implemented. Not much to do with extensions internals (fs.js). Am I mistaken @gcampax ?

[gcampax]

Well, if your extension interface is defined as "read the file or throw an error" - because that's what the sync methods do, then it's up to the async wrapper to turn "throw an error" into "call the callback with an error"

[ktrzeciaknubisa]

You're right @gcampax . The above commit takes care of it internally. However to have this patch in jxcore-android/jxcore-cordova, you need to wait for new binaries release (or compile by yourself).

Thanks!

[gcampax]

Oh I'm compiling everything from source so it's not a problem.

Thanks for addressing this!