-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install && --prefix issue #657
Comments
@ktrzeciaknubisa just tested. It still works for me on 0.3.1.0 |
and what is output of
I'm thinking, that there might be a case when it works if e.g. you have some old |
Right. Just saw the broken output. Better apply the fix. Perhaps the updates I brought from node 0.12 broke it. |
use ./ rather than / for DESTDIR. Closes #657
Done. Do we need to refresh jxcore-cordova due to this folders confusion? |
late comment, but gnu configure expects --prefix to be an absolute dir. It defaults to /usr/local, IIRC |
If a relative directory is desired, From gcc mailing list: https://gcc.gnu.org/ml/gcc/2006-05/msg00646.html |
There is a problem I'm having with
--prefix
value passed to configure script. For example after I use./configure --prefix=some_folder
thenmake install
puts the binaries into the root:/some_folder
instead of current working directory./some_folder
.That makes e.g. ios_compile.sh script failing for me. Take a look at this:
./build_scripts/ios_compile.sh
the it calls e.g.
./configure --prefix=out_ios/ia32 --static-library --dest-os=ios --dest-cpu=ia32 --engine-mozilla
and it displays propernode_prefix
:but
make install
saves them to root/
instead of./
:and then the rest of
ios_compile.sh
script fails, e.g.:yeap, beacause there is no
out_ios/ia32/bin
. There is/out_ios/ia32/bin
(note the root slash in front)I've found a simple solution: change Makefile#L6 from
DESTDIR ?=
toDESTDIR ?= ./
. This is used at tools/install.py#L187-L189 (asargv[2]
) which was empty string until now.I just wonder of two things:
DESTDIR
was not changed.The text was updated successfully, but these errors were encountered: