You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we're getting rid of base64 encoding when passing strings/buffers to _cmp() / _ucmp() (due to #508) I've encountered one file for which _ucmp() fails (returns false).
This is a xml file and comes from one of ghost's sub modules (sax). It's better to download the file rather than copy/paste to editor.
jx install sax@0.4.2
# the file is under node_modules/sax/examples/big-not-pretty.xml
Not really sure what is the problem. I was stripping the file to make it smaller, and so I arrived to the point of this big-not-pretty2.zip (the file is compressed in order to preserve binary format - unzip before use), where removing single (literally any) character from file contents makes the above code work. But the problem is not related to file size, because _ucmp() is working with much bigger files.
The text was updated successfully, but these errors were encountered:
I've also found, that the following files from jxcore repo also have this problems. What came to my eyes is that each of those files contain series of repetitive strings/blocks, for example:
Since we're getting rid of base64 encoding when passing strings/buffers to
_cmp()
/_ucmp()
(due to #508) I've encountered one file for which_ucmp()
fails (returnsfalse
).This is a xml file and comes from one of ghost's sub modules (sax). It's better to download the file rather than copy/paste to editor.
jx install sax@0.4.2 # the file is under node_modules/sax/examples/big-not-pretty.xml
Then the following code shows the problem:
Not really sure what is the problem. I was stripping the file to make it smaller, and so I arrived to the point of this big-not-pretty2.zip (the file is compressed in order to preserve binary format - unzip before use), where removing single (literally any) character from file contents makes the above code work. But the problem is not related to file size, because
_ucmp()
is working with much bigger files.The text was updated successfully, but these errors were encountered: