Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JXP: keep everything in binary format #508

Closed
plika opened this issue Sep 1, 2015 · 7 comments
Closed

JXP: keep everything in binary format #508

plika opened this issue Sep 1, 2015 · 7 comments

Comments

@plika
Copy link
Contributor

plika commented Sep 1, 2015

Current design keeps the structure in a fat JSON which is an absolute time taker. We may introduce a pure binary without an addition base64 / compressor level.

@ktrzeciaknubisa
Copy link
Member

I've taken a measure to implement this and came up with success.

However I needed to disable previous compression methods (jxutils_wrap: _cmp() / _ucmp() ) because I'm operating only on buffers now, while _cmp() receives only strings (unlike _ucmp() which accepts buffers on the other hand).

If someone could give me a hand on this (make _cmp() and eventually CompressString() accept also buffers) I could use that.

@obastemur
Copy link
Member

Let me take care of that ;)

@ktrzeciaknubisa
Copy link
Member

@obastemur Let me know when it's ready :) Than I can go on with the packages binary format.

@karaxuna
Copy link
Member

karaxuna commented Nov 4, 2015

@ktrzeciaknubisa is this what you need? #630

@ktrzeciaknubisa
Copy link
Member

Can't really say. It's closed and 0 commits :)

@karaxuna
Copy link
Member

karaxuna commented Nov 4, 2015

@ktrzeciaknubisa Sorry, I closed that PR, take a look at this one: #631

ktrzeciaknubisa pushed a commit to ktrzeciaknubisa/jxcore-binary-packaging that referenced this issue Nov 9, 2015
ktrzeciaknubisa pushed a commit to ktrzeciaknubisa/jxcore-binary-packaging that referenced this issue Nov 26, 2015
ktrzeciaknubisa pushed a commit to ktrzeciaknubisa/jxcore-binary-packaging that referenced this issue Nov 26, 2015
obastemur added a commit that referenced this issue Dec 18, 2015
@ktrzeciaknubisa
Copy link
Member

Closing the ticket as this is already implemented starting from 0.3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants