Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating row heights on template with multiple areas (using applyAt) #147

Closed
jools-uk opened this issue Oct 20, 2021 · 4 comments
Closed

Updating row heights on template with multiple areas (using applyAt) #147

jools-uk opened this issue Oct 20, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@jools-uk
Copy link

Given a template with multiple jx:area defined, one after the other, with a static top region for each area, and when using xlsArea.applyAt() to transform the areas, updateRowHeights does not correctly copy the height from the source cell. It seems to attempt to lookup the transformed location in the source area and will not find a hit if rows/cols have been added to a prior area. I suspect issue is srcRow, which is not looking at the real source.
@jools-uk jools-uk added the bug Something isn't working label Oct 20, 2021
@jools-uk
Copy link
Author

PR will fully formed Test coming shortly

@jools-uk jools-uk mentioned this issue Oct 27, 2021
Closed
@jools-uk
Copy link
Author

PR created: #149

@jools-uk
Copy link
Author

Add PR with proposed fix:
#150

SoltauFintel added a commit that referenced this issue Dec 16, 2021
@SoltauFintel
#147 code-review
1a80e1c
SoltauFintel added a commit that referenced this issue Dec 16, 2021
@SoltauFintel
#147 Merge branch 'issue147' into feature-147
2e77eed 
Conflicts:
	jxls-site/src/site/markdown/changes.md
@SoltauFintel
Copy link
Member

Another PR #154 with my code-review. Will be part of release 2.12.0.

SoltauFintel added a commit that referenced this issue Dec 17, 2021
@SoltauFintel
#147 row height bugfix
d16445b 
* #147 Test case for row heights when using multiple areas
* #147 Implement fix for row height area start ref
* #147 code-review
jools-uk pushed a commit to jools-uk/jxls that referenced this issue Mar 20, 2022
@SoltauFintel
jxlsteam#147 row height bugfix
7ae9ff5 
* jxlsteam#147 Test case for row heights when using multiple areas
* jxlsteam#147 Implement fix for row height area start ref
* jxlsteam#147 code-review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SoltauFintel @jools-uk