Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue147 Row heights when using multiple areas #149

Closed
wants to merge 2 commits into from
Closed

Issue147 Row heights when using multiple areas #149

wants to merge 2 commits into from

Conversation

jools-uk
Copy link

Updating row heights on template with multiple areas (using applyAt) #147
#147

@jools-uk jools-uk changed the title Issue147 Test case for row heights when using multiple areas Issue147 Row heights when using multiple areas Dec 3, 2021
@jools-uk
Copy link
Author

jools-uk commented Dec 3, 2021

This PR also included proposed fix as well as test

@SoltauFintel
Copy link
Member

@leonate I think you should approve this PR.

@jools-uk
Copy link
Author

jools-uk commented Dec 7, 2021

@SoltauFintel I see approval from @leonate. Isn't this pending your approval?

@SoltauFintel SoltauFintel requested review from SoltauFintel and removed request for SoltauFintel December 7, 2021 22:40
@SoltauFintel
Copy link
Member

@jools-uk oh, yes. I will do it later.

@SoltauFintel
Copy link
Member

Added my code-review (code-style changed + changelog) as PR #154. So this PR is closed.

@jools-uk jools-uk deleted the issue147 branch January 26, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants