Include new model names in _alias.py #426
Conversation
## Include New Model Names CLI does not include new OpenAI models. ## Changes Added the following model names: * `gpt-3.5-turbo-0125` * `gpt-3.5-turbo-instruct` * `gpt-4-0125-preview` * `gpt-4-1106-preview` * `gpt-4-1106-vision-preview` ## Caveats The models `gpt-4-1106-vision-preview` and `gpt-3.5-turbo-instruct` might not be too relevant for users using `Instructor`, but I included them for completeness.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me! Reviewed entire PR up to commit 60c750b
See details
Workflow ID: wflow_tj1lR7PVctZa6xaN
- Reviewed
19lines of code across1files in 11 second(s). - Skipped files:
[none]- If you think a file was skipped (or not skipped) in error, please contact us.
- Confidence threshold (set by
ellipsis.yaml):85% - Drafted
1additional comments.
Drafted 1 comments under confidence threshold
Filtered comment at instructor/_types/_alias.py:6
Confidence changes required: 0%
Commentary: The PR author has added new model names to the list of valid model names. This is a simple change and there doesn't seem to be any logical, performance, or security bugs introduced. The names added are in line with the existing naming convention and the PR description mentions that these are new models. I will check the codebase to see if these model names are used elsewhere and if they need to be updated there as well.
The new model names have been added correctly. Please ensure that these model names are updated in all places where they are used, if applicable.
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
|
Thanks so much! Are you able to also add the embedding models, for both PRs |
Will do! |
|
@jxnl Just added the new embedding models too. Thanks. |
|
@jxnl Done. I've added OpenAI's model literals from here, and embedding literals from here.
|
Include New Model Names
CLI does not include new OpenAI models.
Related to PR from
leobeeson/instructor/patch-1. I should have probably changed both files in the same commit. I'm sorry.Changes
Added the following model names:
gpt-3.5-turbo-0125gpt-3.5-turbo-instructgpt-4-0125-previewgpt-4-1106-previewgpt-4-1106-vision-previewCaveats
The models
gpt-4-1106-vision-previewandgpt-3.5-turbo-instructmight not be too relevant for users usingInstructor, but I included them for completeness.Summary:
This PR updates the
ModelNamestype alias in_alias.pyto include new OpenAI model names.Key points:
ModelNamestype alias in_alias.py.gpt-3.5-turbo-0125,gpt-3.5-turbo-instruct,gpt-4-0125-preview,gpt-4-1106-preview, andgpt-4-1106-vision-preview.Generated with ❤️ by ellipsis.dev