Improve gemini model robustness #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add assertion if model name is passed as a param to create method - map openai args to gemini `generation_config` as per https://ai.google.dev/api/python/google/generativeai/GenerationConfig - avoid import error while configuring gemini safety settings
Sweep: PR ReviewSweep was unable to review your pull request due to the following reasons: Sweep does not support reviewing PRs from forked repositories. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 74975ae in 34 seconds
More details
- Looked at
53lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. instructor/process_response.py:360
- Draft comment:
The assertion to ensure the model name is not passed as a parameter for Gemini is correctly implemented. This aligns with the PR's intent to enforce correct usage patterns for the Gemini model. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions that the assertion is added to ensure the model name is not passed as a parameter to the create method for Gemini. This is correctly implemented in the code. The mapping of OpenAI arguments to Gemini'sgeneration_configis also handled as described. The import forHarmCategoryandHarmBlockThresholdis moved inside the Gemini condition to prevent import errors, which aligns with the PR description. Overall, the changes are consistent with the PR's intent and description.
Workflow ID: wflow_t1y9fpU9zd83wbBW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generation_configas per https://ai.google.dev/api/python/google/generativeai/GenerationConfigSummary:
Enhances Gemini model handling by adding parameter checks, argument mappings, and error handling improvements.
Key points:
modelas a parameter in Gemini mode.generation_config.Generated with ❤️ by ellipsis.dev