Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked
destroy
method to be a little more global, so it can be called by itself from the smoke object. The use case was if using thesmoke
library with the routing system inside of Backbone. If a user navigates to a route, then proceeds to click the back button in the browser and a smoke modal is open, the modal doesn't close.Here is how you can get around the issue with
Backbone.Router
and the changes in this PR: