Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create collection error when name equal to trashed one #198

Merged
merged 7 commits into from
Dec 24, 2018

Conversation

avvertix
Copy link
Contributor

@avvertix avvertix commented Dec 24, 2018

What does this PR do?

Fix a scenario were collections cannot be created if a collection with the same name exists under the same parent, but was trashed.

This also handles these cases

  • Trashing a collection with the same name, creator and type, of an already trashed collection will result in a merge of both in a single collection
  • Restoring a collection now deal with eventual collections created with the same name in the place where the collections needs to be restored

Review checklist

  • Are unit tests required?
  • Are Documentation changes needed?

Before merging

  • Is history cleaned up? (or can be squashed on merge?)

@avvertix avvertix changed the title 760 create collection name equal trashed one Fix create collection error when name equal to trashed one Dec 24, 2018
@avvertix avvertix merged commit 3dd33bd into master Dec 24, 2018
@avvertix avvertix deleted the 760-create-collection-name-equal-trashed-one branch December 24, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant