Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #135, convert prerelease and build to string #140

Merged
merged 8 commits into from Oct 2, 2019
Merged

Fix #135, convert prerelease and build to string #140

merged 8 commits into from Oct 2, 2019

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Sep 29, 2019

This PR fixes #135

Creating VersionInfo(3, 2, 1, 1) succeeds, but fails later when comparing it with another VersionInfo instance (for example, v1 < v2):

    def split_key(key):
>       return [convert(c) for c in key.split('.')]
E       AttributeError: 'int' object has no attribute 'split'

@tomschr
Fix python-semver#135, convert prerelease and build to string
196df65 
Creating VersionInfo(3, 2, 1, 1) succeeds, but fails later when comparing
it with another VersionInfo instance (for example, v1 < v2):

```
    def split_key(key):
>       return [convert(c) for c in key.split('.')]
E       AttributeError: 'int' object has no attribute 'split'
```
Flamefire
Flamefire reviewed Sep 30, 2019
View reviewed changes
Copy link
Contributor

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

What about the other arguments? VersionInfo expects (int, int, int, str, str), so does VersionInfo(10) > VersionInfo('2') == True hold? Maybe add an assert that the first three are int or None?

test_semver.py Outdated Show resolved Hide resolved
@tomschr
Force major, minor, and patch as int
2f5a68d 
To allow VersionInfo(10) > VersionInfo('2') == True
@tomschr
Enhance test_should_compare_prerelease_and_build_with_numbers
ef9abb1 
Add example from python-semver#135
@tomschr
Simplify test case, thanks to Alexander
d708dd7 
Co-authored-by: Alexander Grund
@tomschr
Split test case and check types
a611a73 
Co-authored-by: Alexander Grund
Flamefire
Flamefire reviewed Sep 30, 2019
View reviewed changes
test_semver.py Outdated Show resolved Hide resolved
@tomschr
Move assert line
9361751 
* Move assert line to test_should_be_able_to_use_strings_as_major_minor_patch
* Add additional assert, comparing VersionInfo created
  with strings and with integers

Co-authored-by: Alexander Grund
@scls19fr scls19fr requested a review from k-bx October 1, 2019 05:41
@scls19fr scls19fr mentioned this pull request Oct 1, 2019
Closed
@scls19fr
Copy link
Member

scls19fr commented Oct 2, 2019

Any news about this PR? Is there a general consensus?

@tomschr
Copy link
Member Author

tomschr commented Oct 2, 2019

From my side it's ok, 😉 but would @Flamefire approve? 😉

@scls19fr
Copy link
Member

scls19fr commented Oct 2, 2019

Ok. So let's merge it.
Thanks guys for your work!

@scls19fr scls19fr merged commit 8ee92b4 into python-semver:master Oct 2, 2019
@tomschr tomschr deleted the bugfix/135-conv-args branch October 2, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flamefire Flamefire Flamefire approved these changes

@k-bx k-bx Awaiting requested review from k-bx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert arguments in VersionInfo ctor
3 participants
@tomschr @scls19fr @Flamefire