Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #135, convert prerelease and build to string #140

Merged
merged 8 commits into from
Oct 2, 2019
Merged

Fix #135, convert prerelease and build to string #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
196df65
Fix #135, convert prerelease and build to string
tomschr Sep 29, 2019
2f5a68d
Force major, minor, and patch as int
tomschr Sep 30, 2019
ef9abb1
Enhance test_should_compare_prerelease_and_build_with_numbers
tomschr Sep 30, 2019
d708dd7
Simplify test case, thanks to Alexander
tomschr Sep 30, 2019
a611a73
Split test case and check types
tomschr Sep 30, 2019
9361751
Move assert line
tomschr Sep 30, 2019
45a1049
Integrate tests from Alex, many thanks!
tomschr Oct 1, 2019
db85106
Remove v variable to silence flake8
tomschr Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions semver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ def __init__(self, major, minor=0, patch=0, prerelease=None, build=None):
self._major = major
self._minor = minor
self._patch = patch
self._prerelease = prerelease
self._build = build
self._prerelease = None if prerelease is None else str(prerelease)
self._build = None if build is None else str(build)

@property
def major(self):
Expand Down
6 changes: 6 additions & 0 deletions test_semver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,3 +497,9 @@ def test_immutable_unknown_attribute(version):
def test_version_info_should_be_iterable(version):
assert tuple(version) == (version.major, version.minor, version.patch,
version.prerelease, version.build)


def test_should_compare_prerelease_and_build_with_numbers():
v1 = VersionInfo(major=1, minor=9, patch=1, prerelease=1, build=1)
v2 = VersionInfo(major=1, minor=9, patch=1, prerelease=2, build=1)
tomschr marked this conversation as resolved.
Show resolved Hide resolved
assert v1 < v2