-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine said that the package was ingested, but it did not include all of the titles #492
Comments
Looking in the log, the server thinks there were only 100 lines in the file, so it processed everything sent. If I can get the source file I'll dig. |
Heya - when I open that file in refine, it only shows 100 titles, although there are 150 in the file - can you confirm you do/don't see something different? cheers, |
Ignore me :) |
Yes, I see 150. On Thu, Apr 7, 2016 at 1:36 PM, Ian Ibbotson notifications@github.com
Jennifer Solomon |
Ok - sensible debugging this time :) can you take a look at line 160 of that file and see if you have a line like 3-0283 full text Ceased publication S. Karger AG In the middle of the file? |
Seeing this in refine conversation, logged in client 19:13:24.825 [ command] Exception caught (41ms) |
Righty :) At some point we have upped the batch size from 25 to 100 rows inside the cred. It looks like we forgot to update a bit of logic that adjusts for a number of rows exactly on that boundary. Because 150 / 25 fits, we were finding the error case. I've updated it and I think the Karger package is ingesting now. J - could you give it another whirl please? |
P.S. temporarily commented out updating of user updating package via refine, will put it back in once we're sure this is fixed. |
Cool. This time all of the titles were ingested. On Thu, Apr 7, 2016 at 3:28 PM, Ian Ibbotson notifications@github.com
Jennifer Solomon |
fix confirmed |
In Karger: Journals Collection: Test 1 and Karger: Journals Collection: Test 2 there are 150 titles. Only 100 were ingested, but Refine did not flag this as a partial ingest.
The text was updated successfully, but these errors were encountered: