Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with upstream Grafana SDK changes? #56

Closed
slimsag opened this issue Mar 31, 2020 · 2 comments · Fixed by #57
Closed

Incompatible with upstream Grafana SDK changes? #56

slimsag opened this issue Mar 31, 2020 · 2 comments · Fixed by #57

Comments

@slimsag
Copy link
Contributor

slimsag commented Mar 31, 2020

Running go get on this as a dependency fails:

$ mkdir foo && cd foo/
$ go mod init foo.com/foo
go: creating new go.mod: module foo.com/foo
$ go get -u github.com/K-Phoen/grabana
go: github.com/K-Phoen/grabana upgrade => v0.6.3
go: github.com/grafana-tools/sdk upgrade => v0.0.0-20200326200416-f0431e44c1c3
go: github.com/gosimple/slug upgrade => v1.9.0
# github.com/K-Phoen/grabana/alert
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/alert.go:128:25: cannot use conditionOperator literal (type conditionOperator) as type sdk.AlertOperator in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:57:22: cannot use query literal (type query) as type sdk.AlertQuery in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:58:24: cannot use reducer literal (type reducer) as type sdk.AlertReducer in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:66:22: cannot use query literal (type query) as type sdk.AlertQuery in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:67:24: cannot use reducer literal (type reducer) as type sdk.AlertReducer in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:75:22: cannot use query literal (type query) as type sdk.AlertQuery in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:76:24: cannot use reducer literal (type reducer) as type sdk.AlertReducer in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:84:22: cannot use query literal (type query) as type sdk.AlertQuery in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:85:24: cannot use reducer literal (type reducer) as type sdk.AlertReducer in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:93:22: cannot use query literal (type query) as type sdk.AlertQuery in assignment
../pkg/mod/github.com/!k-!phoen/grabana@v0.6.3/alert/condition.go:93:22: too many errors
@slimsag
Copy link
Contributor Author

slimsag commented Mar 31, 2020

Note: copying the grafana-sdk version from the go.mod in this repository works around the issue, so this is just a simple incompatibility issue with some upstream changes.

@K-Phoen
Copy link
Owner

K-Phoen commented Mar 31, 2020

this is just a simple incompatibility issue with some upstream changes.

Correct :)

Should be fixed by #57, thanks for opening this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants