Feat: 상품 썸네일 및 판매시작 api 연동 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyaaany
force-pushed
the
#114/product-confirm-page
branch
2 times, most recently
from
59196db
to
a9bd76a
Compare
jiyaaany
commented
Nov 17, 2021
|
어디서부터 봐야하는건가욤,,? |
|
^ 이거 작업 마무리되면 2-1(2-3) 배포합시다 |
|
a9bd76a 이 커밋만 확인해주세욥 ! |
YuuRiLee
reviewed
Nov 26, 2021
src/pages/CreateProduct/components/Footer/hooks/useSaveProduct.ts
Outdated
Show resolved
Hide resolved
jiyaaany
force-pushed
the
#114/product-confirm-page
branch
from
9a80b3b
to
c268cc3
Compare
YuuRiLee
reviewed
Nov 30, 2021
| @@ -4,7 +4,7 @@ import styled from 'styled-components'; | |||
| import { theme } from 'themes'; | |||
|
|
|||
| export const ProductCard = styled(Link)` | |||
| color: #000; | |||
| color: ${theme.palette.common.black}; | |||
There was a problem hiding this comment.
Q: color: ${palette.text.secondary}; 이런거 안써주시고 새로 정의하신 이유가 궁금해욤
There was a problem hiding this comment.
A: 정의한게 아니라 palette 정의된거 보니까 기본으로 common이라는 객체가 있고 그 안에 white, black 있습니당!
palette.ts에 common 정의되어있는거 제가 한 것 같은데 ,, 왜 추가했는지 ,, 기억도 나지 않고 제거해도 동일하게 작동하네요 (33789a3 )
${palette.text.secondary}는 회색인 것 같슴다
node_modules/@material-ui/core/styles/createPalette.d.ts
There was a problem hiding this comment.
${palette.text.primary}도 있어용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 제안 사유
/productapi를 연동합니다.Resolves #114 #115
주요 변경 기록
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷
기타 질문 및 특이 사항