Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 상품 썸네일 및 판매시작 api 연동 #124

Merged
merged 14 commits into from
Dec 5, 2021
Merged

Feat: 상품 썸네일 및 판매시작 api 연동 #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
19948f4
style: 헤더와 컨텐츠 사이 margin 추가
Oct 8, 2021
f21dc0f
feat: 상품 확인 페이지
Oct 8, 2021
a63f392
feat: 판매 시작 api 연동
Oct 8, 2021
dea6508
refactor: 판매 시작 api react-query로 호출
Oct 20, 2021
741b3c1
refactor: 상품 썸네일 마크업 리팩터링
Oct 20, 2021
bfb545d
refactor: palette 컬러코드 추가
Oct 25, 2021
e4c709c
refactor: splitText 공통 함수 분리
Oct 25, 2021
8950c1b
refactor: onError 발생 시 openErrorSnackbar 변경
Oct 25, 2021
5448c46
feat: 상품 등록 단계별 api 호출로직 훅으로 분리
Nov 17, 2021
c268cc3
refactor: 리턴 데이터 타입 제네릭 타입으로 수정
jiyaaany Nov 28, 2021
33789a3
remove: common black 컬러 제거
Nov 30, 2021
52ec7e6
chore: yarn.lock 파일 수정된 거 복구
jiyaaany Nov 30, 2021
76ed7ea
remove: usePost에서 error 스낵바 처리를 하고 있어 useSaveProduct 훅에서 제거
jiyaaany Nov 30, 2021
eb76c79
refactor: palette text 컬러로 수정
jiyaaany Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/CreateProduct/Confirm/index.css.ts → ...ages/CreateProduct/Confirm/Confirm.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styled from 'styled-components';
import { theme } from 'themes';

export const ProductCard = styled(Link)`
color: #000;
color: ${theme.palette.common.black};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: color: ${palette.text.secondary}; 이런거 안써주시고 새로 정의하신 이유가 궁금해욤

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A: 정의한게 아니라 palette 정의된거 보니까 기본으로 common이라는 객체가 있고 그 안에 white, black 있습니당!
palette.ts에 common 정의되어있는거 제가 한 것 같은데 ,, 왜 추가했는지 ,, 기억도 나지 않고 제거해도 동일하게 작동하네요 (33789a3 )
${palette.text.secondary}는 회색인 것 같슴다

image
node_modules/@material-ui/core/styles/createPalette.d.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${palette.text.primary}도 있어용

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eb76c79 수정했어용

text-decoration: none;
width: ${theme.spacing(55)};
border: 5px solid ${theme.palette.grey[200]};
Expand Down
2 changes: 1 addition & 1 deletion src/pages/CreateProduct/Confirm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
InfoMessage,
Price,
Tag,
} from './index.css';
} from './Confirm.css';

const Confirm = (): React.ReactElement => {
const { name, fullPrice, discountPrice, representativeImageUrl, tags } =
Expand Down
3 changes: 3 additions & 0 deletions src/themes/palette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { deepOrange } from './colors/deepOrange';

export const { palette } = createMuiTheme({
palette: {
common: {
black: '#000',
},
primary: {
light: deepOrange[200],
main: deepOrange[600],
Expand Down