-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minpac#status() function for showing status of plugins. #56 #58
Conversation
664f993
to
3561412
Compare
I'm not sure why appveyor is failing. |
The appveyor environment didn't support Vim 8.1. |
Ok, should i rebase to make this pass? |
autoload/minpac/impl.vim
Outdated
if !isdirectory(l:dir) | ||
let l:plugin.status = 'Not installed' | ||
else | ||
let l:commits = systemlist([g:minpac#opt.git, '-C', l:dir, 'log', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to use systemlist()
(or system()
), because it opens a command window on Windows.
Can you use s:system()
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried, but that won't return any results. I tried increasing sleep to 1000m in s:system, but still i get empty results back. Do you have idea why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. It works. Pushed a fix.
Can I see a screen shot of this? |
Thank you for your work @kristijanhusak: this is something I was missing coming from vim-plug. 😃 You might want to add To display some of that signature information in a way that fits one-line outputs, you could use the |
@pierremoreau thanks for the feedback! I guess i'll just remove the signature, it's not really important. I also plan to add a preview of commit by clicking on it in the list. |
5d1fd7d
to
4f03fcf
Compare
@k-takata I moved some code around, hope it's fine by you. |
Sorry for the delay, but thank you for adding the |
Great @pierremoreau, thanks for testing. @k-takata , is there something more to be done here? |
…ak/minpac into devel Merge PR #58 into devel.
I have merged this into the devel branch (with some modifications). |
Great, thanks! |
I have released v2.0. |
Initial version of status list.
Shows only installed/updated plugins after
minpac#update()
is called.Otherwise, returns status of all plugins.
It works similar to vim-plug, but lot of feature are missing (commit preview, handling each commit separately, etc.)
This satisfies my requirement for now, and it can be extended later on.