Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pack to correct folder if already existing but on different type (opt/start) #46

Closed
wants to merge 3 commits into from

Conversation

melantronica
Copy link

If a minpac#add() call was changed to use a pack inside 'opt' instead 'start' it was resulting in having 2 copies of the pack. With this patch it will simply be moved to the path specified.

The regex specifying the path to be substituted could catch false positives if g:minpac#opt.minpac_start_dir would contain multiple occurrences of '/start/' or '/opt/'.

Bastian Zeller and others added 3 commits December 17, 2017 16:52
@k-takata
Copy link
Owner

Sorry for the very late response.

Could you explain why you added --recurse-submodules?
The option is relatively new and only available with 2.13 or later. https://stackoverflow.com/a/4438292/4570471
So I want to avoid using the option. (e.g. Ubuntu 16.04 comes with Git 2.7.4)
Currently, minpac executes git submodule update --init --recursive after git clone or git pull.

@melantronica
Copy link
Author

Most likely I have overseen the implementation in the callback.
After rechecking, I agree with you. Its redundant.

k-takata added a commit that referenced this pull request Aug 22, 2018
@k-takata
Copy link
Owner

I have merged this into the devel branch.

k-takata added a commit that referenced this pull request Aug 30, 2018
k-takata added a commit that referenced this pull request Aug 30, 2018
@k-takata
Copy link
Owner

k-takata commented Sep 1, 2018

I have released v2.0 which includes the first commit of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants