Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linq creators #15

Merged
merged 6 commits into from
May 13, 2016
Merged

Linq creators #15

merged 6 commits into from
May 13, 2016

Conversation

babelvit
Copy link
Contributor

@babelvit babelvit commented May 12, 2016

in order to build with cygwin, '-std=c++11' flag does not allow cygwin/mingw
compiler to use gnu (non-standard) functions, '-std=gnu++11' does
in order to build with cygwin, maybe because of new benchmark version
return Enumerator<TT,DataType>([](DataType & pair){
return (pair.first == pair.second.cend()) ? throw EnumeratorEndException() : *(pair.first++);
}, DataType(container, [](const TV<TT,TU> & cont){return cont.cbegin();}));
return from<TT>(std::begin(container), std::end(container));
Copy link
Contributor Author

@babelvit babelvit May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing a reason, why these was not simple like this from beginning?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification, really like it!

@k06a k06a merged commit fb57871 into k06a:master May 13, 2016
@babelvit babelvit deleted the linq-creators branch May 14, 2016 15:50
@k06a
Copy link
Owner

k06a commented May 27, 2016

@babelvit looks like we need to configure appveyor.com as travis-ci.org to run tests on MinGW for every pull-request. Do you have experience with this service? Maybe u'll help me to configure it?

@babelvit
Copy link
Contributor Author

@k06a Well, I have no experience even with this technology, but I will read about it sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants