[Backport release-1.27] Clear error in Helm chart status after successful reconciliation #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use WithError to report errors in logs * Use error wrapping in fmt.Errorf where applicable * Raise log level from trace to debug for some log statements * Don't log-and-return errors * Fix typo: reconcilation Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 03ec4f0)
Whenever errors occur during the reconciliation of Helm charts, they are recorded in the error field of the Chart resource. However, the error status field was not cleared after a subsequent successful reconciliation, which caused the Chart resource's status to erroneously report the chart application as failed, even if it had recovered. To address this, the error status should be cleared whenever there are no errors. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit d9bc239)
16 tasks
juanluisvaladas
approved these changes
May 5, 2023
twz123
added
bug
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.26
git worktree add -d .worktree/backport-3070-to-release-1.26 origin/release-1.26
cd .worktree/backport-3070-to-release-1.26
git checkout -b backport-3070-to-release-1.26
ancref=$(git merge-base c71b9fc63c9183a58d75ff40a9bdf1a420bbc3bb 8cacb4def56adc0d24fce092d461d013eff74d64)
git cherry-pick -x $ancref..8cacb4def56adc0d24fce092d461d013eff74d64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.27, triggered by a label in #3053.See #3045.