[Backport release-1.25] Clear error in Helm chart status after successful reconciliation #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use WithError to report errors in logs * Use error wrapping in fmt.Errorf where applicable * Raise log level from trace to debug for some log statements * Don't log-and-return errors * Fix typo: reconcilation Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 03ec4f0) (cherry picked from commit a88dba3) (cherry picked from commit c7c9859)
Whenever errors occur during the reconciliation of Helm charts, they are recorded in the error field of the Chart resource. However, the error status field was not cleared after a subsequent successful reconciliation, which caused the Chart resource's status to erroneously report the chart application as failed, even if it had recovered. To address this, the error status should be cleared whenever there are no errors. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit d9bc239) (cherry picked from commit 8cacb4d) (cherry picked from commit 734809d)
twz123
changed the title
twz123
added
bug
makhov
approved these changes
May 10, 2023
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.24
git worktree add -d .worktree/backport-3097-to-release-1.24 origin/release-1.24
cd .worktree/backport-3097-to-release-1.24
git checkout -b backport-3097-to-release-1.24
ancref=$(git merge-base 1dd361c23625d9371f84d9cc8bac62897ebe839f 500917163d69a8f682ac90e85d019b7d8106485c)
git cherry-pick -x $ancref..500917163d69a8f682ac90e85d019b7d8106485c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.25, triggered by a label in #3092.See #3070 #3045.