Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize Windows and POSIX constants #4043

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 8, 2024

Description

Deduplicate identical pause image constants. Remove constants that are no longer used. Synchronize doc strings between the Windows and POSIX constants.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Deduplicate identical pause image constants. Remove constants that are
no longer used. Synchronize doc strings between the Windows and POSIX
constants.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Feb 8, 2024
@twz123 twz123 marked this pull request as ready for review February 8, 2024 19:59
@twz123 twz123 requested a review from a team as a code owner February 8, 2024 19:59
@twz123 twz123 requested review from kke and makhov February 8, 2024 19:59
@twz123 twz123 merged commit dd33867 into k0sproject:main Feb 13, 2024
74 checks passed
@twz123 twz123 deleted the sync-constants branch February 13, 2024 20:37
@twz123 twz123 mentioned this pull request Feb 19, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants