Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.28] Set correct version number in containerd CRI config #4602

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

k0s-bot
Copy link

@k0s-bot k0s-bot commented Jun 12, 2024

Automated backport to release-1.28, triggered by a label in #4589.
See #4569 #4568.

@k0s-bot k0s-bot requested a review from a team as a code owner June 12, 2024 08:33
@k0s-bot k0s-bot requested review from twz123 and jnummelin June 12, 2024 08:33
@twz123 twz123 changed the title [Backport release-1.28] [Backport release-1.29] Set correct version number in containerd CRI config [Backport release-1.28] Set correct version number in containerd CRI config Jun 12, 2024
@twz123 twz123 added bug Something isn't working area/configuration component/containerd backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch labels Jun 12, 2024
The version number has to be lowercase, otherwise it won't be picked up
by containerd. If the version is missing, containerd might not do the
right thing when merging configuration values.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
(cherry picked from commit 15b0427)
(cherry picked from commit 47cd335)
(cherry picked from commit f04fb5a)
@twz123 twz123 force-pushed the backport-4589-to-release-1.28 branch from 9671c04 to 50e96bf Compare June 14, 2024 13:33
@twz123 twz123 merged commit 08754cb into release-1.28 Jun 17, 2024
72 checks passed
@twz123 twz123 deleted the backport-4589-to-release-1.28 branch June 17, 2024 12:23
@k0s-bot
Copy link
Author

k0s-bot commented Jun 17, 2024

Successfully created backport PR for release-1.27:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch bug Something isn't working component/containerd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants