Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate MachineID existence & uniqueness #435

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Validate MachineID existence & uniqueness #435

merged 3 commits into from
Dec 16, 2022

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 15, 2022

Signed-off-by: Kimmo Lehto klehto@mirantis.com

Fixes #434

Checks on each host that /etc/machine-id or /var/lib/dbus/machine-id exists and that it is unique.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke added the enhancement New feature or request label Dec 15, 2022
@kke
Copy link
Contributor Author

kke commented Dec 15, 2022

Debian10 busted!

time="2022-12-15T07:35:07Z" level=fatal msg="failed on 2 hosts:\n - [ssh] 127.0.0.1:9022: machine id 3766705eb195582e8168a9a1b913c7c7 is not unique: manager0\n - [ssh] 127.0.0.1:9023: machine id 3766705eb195582e8168a9a1b913c7c7 is not unique: worker0"

weaveworks/footloose#280

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke requested a review from jnummelin December 15, 2022 08:14
@kke kke merged commit b0cd9d9 into main Dec 16, 2022
@kke kke deleted the validate-machineid branch December 16, 2022 08:06
bfritz added a commit to bfritz/homelab-bootstrap that referenced this pull request Jan 15, 2023
Run `/etc/init.d/machine-id` on startup because k0sctl now performs
a uniqueness check when building the cluster:
k0sproject/k0sctl#435

Release notes:
https://github.com/k0sproject/k0sctl/releases/tag/v0.15.0
bfritz added a commit to bfritz/homelab-bootstrap that referenced this pull request Jan 15, 2023
Run `/etc/init.d/machine-id` on startup because k0sctl now performs
a uniqueness check when building the cluster:
k0sproject/k0sctl#435

Release notes:
https://github.com/k0sproject/k0sctl/releases/tag/v0.15.0
bors bot added a commit to bfritz/homelab-bootstrap that referenced this pull request Jan 15, 2023
71: k0s: update k0sctl from version 0.14.0 to 0.15.0 r=bfritz a=bfritz

Run `/etc/init.d/machine-id` on startup because k0sctl now performs a uniqueness check when building the cluster:
k0sproject/k0sctl#435

Release notes:
https://github.com/k0sproject/k0sctl/releases/tag/v0.15.0

Co-authored-by: Brad Fritz <github@bfritz.com>
twz123 added a commit to twz123/k0sctl that referenced this pull request May 3, 2024
This reverts commit b0cd9d9.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for /etc/machine-id uniqueness
1 participant