Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy networkConfig for every node #523

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

juanluisvaladas
Copy link
Contributor

Every controller with dynamiConfig needs a properly configured .spec.network, this is required because otherwise the component managers for network components may start synchronizing before getting the configuration dynamically.

Partially fixes k0sproject/k0s#3304

This doesn't impact negatively worker nodes.

Every controller with dynamiConfig needs a properly configured
.spec.network, this is required because otherwise the component managers
for network components may start synchronizing before getting the
configuration dynamically.

Partially fixes k0sproject/k0s#3304

This doesn't impact negatively worker nodes.

Signed-off-by: Juan Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it wouldn't matter even if the whole config was copied as k0s itself handles the splitting upon startup.

@kke kke merged commit 7decf5b into k0sproject:main Aug 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reboot of the first control plane with dynamicConfig breaks Calico & Helm Charts
2 participants