Worker upgrade started after Pods became Ready #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
reviewed
Aug 28, 2023
| type KubeSystemEvent struct { | ||
| Items []struct { | ||
| Reason string `json:"reason"` | ||
| EventTime string `json:"eventTime"` |
There was a problem hiding this comment.
Did you try with just time.Time? I'd expect it to work as these kube jsons should come straight from go's json.Marshal
kke
reviewed
Aug 28, 2023
|
|
||
| // Returns true if a "schedule" is found from an event newer than the time specified in the argument. | ||
| func (h *Host) FindScheduleFromKubeSystemEvents(now time.Time) (bool, error) { | ||
| output, err := h.ExecOutput(h.Configurer.K0sCmdf("kubectl -n kube-system get events -o json"), exec.Sudo(h)) |
There was a problem hiding this comment.
I think something like this should work:
kubectl -n kube-system get events --field-selector reason=Scheduled -o jsonThis should make it possible to remove some extra logic.
|
Thank you. |
For more information, see the following Issue Fixes: k0sproject#537 Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
upgrade-wait-kubesystem-pods-ready
branch
from
63a7c89
to
50a4a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During cluster upgrade, change to start worker node upgrade after all kube-system pods are up and running, instead of immediately updating the control plane after the control plane upgrade is finishe>
The reason for the change is to eliminate service downtime. Prior to this change, some services would be down for tens of seconds during worker node upgrades.
For more information, see the following Issue
Fixes: #537