Skip to content

Commit

Permalink
rgw/notifications: cleanup all coroutines after sending the notification
Browse files Browse the repository at this point in the history
this is fixing a regression from: 6b6592f

Fixes: https://tracker.ceph.com/issues/63580

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
  • Loading branch information
yuvalif committed Nov 19, 2023
1 parent ab23068 commit 63e1489
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/rgw/rgw_op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7283,14 +7283,15 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key& o, optional_
op_ret = 0;
}

send_partial_response(o, del_op->result.delete_marker, del_op->result.version_id, op_ret, formatter_flush_cond);

// send request to notification manager
int ret = res->publish_commit(this, obj_size, ceph::real_clock::now(), etag, version_id);
if (ret < 0) {
ldpp_dout(this, 1) << "ERROR: publishing notification failed, with error: " << ret << dendl;
// too late to rollback operation, hence op_ret is not set here
}

send_partial_response(o, del_op->result.delete_marker, del_op->result.version_id, op_ret, formatter_flush_cond);
}

void RGWDeleteMultiObj::execute(optional_yield y)
Expand Down

0 comments on commit 63e1489

Please sign in to comment.