Merge pull request #11 from k1LoW/msg-prefix

Add message prefix

analyzer/decisions/pkgnames/testdata/src/b_bar/b.go

@@ -1,3 +1,3 @@
-package b_bar // want "package"
+package b_bar // want "gostyle.pkgnames"
 
 func f() {}

analyzer/decisions/pkgnames/testdata/src/util/util.go

@@ -1,3 +1,3 @@
-package util // want "package"
+package util // want "gostyle.pkgnames"
 
 func f() {}

analyzer/effective/ifacenames/ifacenames.go

@@ -16,6 +16,7 @@ const (
 	name = "ifacenames"
 	doc  = "Analyzer based on https://go.dev/doc/effective_go#interface-names."
 	msg  = "by convention, one-method interfaces are named by the method name plus an -er suffix or similar modification to construct an agent noun. (ref: https://go.dev/doc/effective_go#interface-names)"
+	msgc = "all interface names with the -er suffix are required. (THIS IS NOT IN Effective Go)"
 )
 
 var (
@@ -65,7 +66,7 @@ func run(pass *analysis.Pass) (any, error) {
 				}
 			}
 			if all && !strings.HasSuffix(ii.Name, "er") {
-				r.Append(n.Pos(), fmt.Sprintf("%s: %s", "all interface names with the -er suffix are required.", ii.Name))
+				r.Append(n.Pos(), fmt.Sprintf("%s: %s", msgc, ii.Name))
 				return
 			}
 		case *ast.Ident:

analyzer/effective/ifacenames/testdata/src/a/a.go

@@ -1,10 +1,10 @@
 package a
 
-type Query interface { // want "-er suffix"
+type Query interface { // want "gostyle.ifacenames"
 	Do() error
 }
 
-type Closer interface { // want "-er suffix"
+type Closer interface { // want "gostyle.ifacenames"
 	Do() error
 }
 

analyzer/effective/ifacenames/testdata/src/b/b.go

@@ -1,18 +1,18 @@
 package b
 
-type Query interface { // want "-er suffix"
+type Query interface { // want "gostyle.ifacenames"
 	Do() error
 }
 
-type Closer interface { // want "-er suffix"
+type Closer interface { // want "gostyle.ifacenames"
 	Do() error
 }
 
 type Writer interface {
 	Write() error
 }
 
-type Add interface { // want "-er suffix"
+type Add interface { // want "gostyle.ifacenames"
 	One() error
 	Two() error
 }

analyzer/guide/mixedcaps/testdata/src/a/a.go

@@ -1,13 +1,13 @@
 package a
 
-const MAX_LENGTH = 10 // want "MixedCaps"
+const MAX_LENGTH = 10 // want "gostyle.mixedcaps"
 
-func f_a() { // want "MixedCaps"
-	var go_Pher int // want "MixedCaps"
-	print(go_Pher)  // want "MixedCaps"
+func f_a() { // want "gostyle.mixedcaps"
+	var go_Pher int // want "gostyle.mixedcaps"
+	print(go_Pher)  // want "gostyle.mixedcaps"
 }
 
-type T_a struct { // want "MixedCaps"
+type T_a struct { // want "gostyle.mixedcaps"
 	foo_bar int //nolint:all
 }
 

reporter/reporter.go

@@ -11,6 +11,7 @@ import (
 )
 
 const (
+	msgPrefix                = "gostyle"
 	NoLintCommentAnnotation  = "nolint:"
 	NoStyleCommentAnnotation = "nostyle:"
 	LintIgnore               = "lint:ignore"
@@ -46,7 +47,7 @@ func (r *Reporter) Report() {
 		if r.IgnoreReport(report.Pos) {
 			continue
 		}
-		r.pass.Reportf(report.Pos, report.Msg)
+		r.pass.Reportf(report.Pos, fmt.Sprintf("[%s.%s] %s", msgPrefix, r.name, report.Msg))
 	}
 }