Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiple Matchers Consuming Request Body Causing Stub Handler Failure #28

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

qawatake
Copy link
Contributor

@qawatake qawatake commented Dec 9, 2023

This PR has fixed a bug where the stub handler would fail when there are multiple matchers that use the request body for matching.

This issue occurs particularly in scenarios where the path and method match exactly, and the API type, such as jsonrpc 1, is included within the request body. In cases of stubbing APIs that incorporate the API type or operation kind in the request body, there might be multiple matchers specified that consume the request body.

Footnotes

  1. https://www.jsonrpc.org/specification

@k1LoW k1LoW added the bug Something isn't working label Dec 9, 2023
@k1LoW
Copy link
Owner

k1LoW commented Dec 9, 2023

@qawatake Thank you!!!!

@k1LoW k1LoW merged commit beac411 into k1LoW:main Dec 9, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants