Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps go directive the lowest supported major version #980

Closed
Arthur1 opened this issue Jun 28, 2024 · 1 comment · Fixed by #1015
Closed

Keeps go directive the lowest supported major version #980

Arthur1 opened this issue Jun 28, 2024 · 1 comment · Fixed by #1015
Assignees
Labels
go Pull requests that update Go code

Comments

@Arthur1
Copy link

Arthur1 commented Jun 28, 2024

I'm developing runnreceiver that can run tests and generate metrics with runn in OpenTelemetry Collector.

I provide pre-built OpenTelemetry Collector binaries which include runnreceiver, but almost all users build with runnreceiver and any other components. In other words, runnreceiver is also used as a library.

In go.mod file of runn and other libaries, go directive is already set to 1.22.

runn/go.mod

Line 3 in b607f60

go 1.22.4

Go 1.21 is still an officially supported version that may be used by end users, but you can't build on the version as long as it depends on runn and the libraries that depend on runn.

I understand that this is a tough problem to address right away. I would appreciate it if you would consider keeping the go directive when the next major version of Go is released.

@k1LoW k1LoW self-assigned this Jun 30, 2024
@k1LoW
Copy link
Owner

k1LoW commented Jul 1, 2024

@Arthur1 Thank you for your feedback!

I have created https://github.com/k1LoW/oldstable and will introduce it in the next version.

@k1LoW k1LoW added the go Pull requests that update Go code label Jul 24, 2024
@k1LoW k1LoW mentioned this issue Aug 14, 2024
@k1LoW k1LoW closed this as completed in 395f0cd Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants