Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with validators behaving incorrectly when running concurrently #902

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 30, 2024

ref: #882

@k1LoW k1LoW added the bug Something isn't working label Apr 30, 2024
@k1LoW k1LoW self-assigned this Apr 30, 2024

This comment has been minimized.

@k1LoW
Copy link
Owner Author

k1LoW commented Apr 30, 2024

OK

--- FAIL: TestOpenAPI3Validator (0.01s)
    --- FAIL: TestOpenAPI3Validator/16 (0.00s)
        http_validator_test.go:546: got error: openapi3 validation error: Error: GET operation request content type 'GET' does not exist, Reason: The path was found, but there was no 'GET' method found in the spec, Line: 7, Column: 3
            -----START HTTP REQUEST-----
            GET /users5 HTTP/0.0
            Accept: application/json
            
            
            -----END HTTP REQUEST-----
    --- FAIL: TestOpenAPI3Validator/15 (0.00s)
        http_validator_test.go:546: got error: openapi3 validation error: Error: GET operation request content type 'GET' does not exist, Reason: The path was found, but there was no 'GET' method found in the spec, Line: 7, Column: 3
            -----START HTTP REQUEST-----
            GET /users6/3 HTTP/0.0
            Accept: application/json
            
            
            -----END HTTP REQUEST-----

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review April 30, 2024 03:44

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #902 (4201ae2) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,972,719,444 ns/op 3,716,096,257 ns/op -256,623,187 ns/op
Bytes allocated per iteration 1,793,307,720 B/op 1,792,836,048 B/op -471,672 B/op
Allocs per iteration 21,420,030 allocs/op 21,419,434 allocs/op -596 allocs/op
Metadata
main (-) #902 (4201ae2)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #902 (4201ae2) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,952,425,519 ns/op 5,214,406,663 ns/op 261,981,144 ns/op
Bytes allocated per iteration 2,944,918,064 B/op 2,944,799,288 B/op -118,776 B/op
Allocs per iteration 29,262,818 allocs/op 29,263,802 allocs/op 984 allocs/op
Metadata
main (-) #902 (4201ae2)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #902 (4201ae2) +/-
Number of iterations 19 18 -1
Nanoseconds per iteration 64,227,825 ns/op 63,787,709 ns/op -440,116 ns/op
Bytes allocated per iteration 60,332,720 B/op 60,298,845 B/op -33,875 B/op
Allocs per iteration 205,909 allocs/op 205,859 allocs/op -50 allocs/op
Metadata
main (-) #902 (4201ae2)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (3f5d523) #902 (4201ae2) +/-
Coverage 65.6% 65.6% +0.0%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Details
  |                    | main (3f5d523) | #902 (4201ae2) |  +/-  |
  |--------------------|----------------|----------------|-------|
+ | Coverage           |          65.6% |          65.6% | +0.0% |
  |   Files            |             71 |             71 |     0 |
  |   Lines            |           7679 |           7686 |    +7 |
+ |   Covered          |           5037 |           5042 |    +5 |
+ | Code to Test Ratio |          1:0.5 |          1:0.5 |  +0.0 |
  |   Code             |          22362 |          22371 |    +9 |
+ |   Test             |          10252 |          10262 |   +10 |

Code coverage of files in pull request scope (64.3% → 64.4%)

Files Coverage +/-
coverage.go 79.5% 0.0%
http_validator.go 81.5% -0.5%
runner_option.go 37.5% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 2481d4d into main Apr 30, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-conc-validate branch April 30, 2024 08:38
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
@k1LoW k1LoW changed the title Fix problem with validators behaving incorrectly when running concurrently Fix problem with validators behaving incorrectly when running concurrently (This is not a sufficient fix.) Apr 30, 2024
@k1LoW k1LoW changed the title Fix problem with validators behaving incorrectly when running concurrently (This is not a sufficient fix.) Fix problem with validators behaving incorrectly when running concurrently Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant