Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for problem with validators behaving incorrectly when running concurrently #906

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 30, 2024

@k1LoW k1LoW added the bug Something isn't working label Apr 30, 2024
@k1LoW k1LoW self-assigned this Apr 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as draft April 30, 2024 11:55

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW changed the title Fix problem with validators behaving incorrectly when running concurrently Add test for problem with validators behaving incorrectly when running concurrently Apr 30, 2024
@k1LoW k1LoW marked this pull request as ready for review April 30, 2024 23:35
@k1LoW k1LoW changed the title Add test for problem with validators behaving incorrectly when running concurrently Fix test for problem with validators behaving incorrectly when running concurrently Apr 30, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #906 (615a192) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,828,637,136 ns/op 4,030,704,198 ns/op 202,067,062 ns/op
Bytes allocated per iteration 1,792,101,208 B/op 1,792,380,200 B/op 278,992 B/op
Allocs per iteration 21,406,167 allocs/op 21,406,490 allocs/op 323 allocs/op
Metadata
main (-) #906 (615a192)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #906 (615a192) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,224,460,322 ns/op 5,139,860,338 ns/op -84,599,984 ns/op
Bytes allocated per iteration 2,945,095,240 B/op 2,945,167,624 B/op 72,384 B/op
Allocs per iteration 29,267,357 allocs/op 29,270,848 allocs/op 3,491 allocs/op
Metadata
main (-) #906 (615a192)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #906 (615a192) +/-
Number of iterations 16 16 0
Nanoseconds per iteration 66,868,862 ns/op 65,286,193 ns/op -1,582,669 ns/op
Bytes allocated per iteration 60,304,917 B/op 60,265,084 B/op -39,833 B/op
Allocs per iteration 205,787 allocs/op 205,743 allocs/op -44 allocs/op
Metadata
main (-) #906 (615a192)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (e81e116) #906 (615a192) +/-
Coverage 65.6% 65.6% 0.0%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Details
  |                    | main (e81e116) | #906 (615a192) | +/-  |
  |--------------------|----------------|----------------|------|
  | Coverage           |          65.6% |          65.6% | 0.0% |
  |   Files            |             71 |             71 |    0 |
  |   Lines            |           7685 |           7685 |    0 |
  |   Covered          |           5041 |           5041 |    0 |
+ | Code to Test Ratio |          1:0.5 |          1:0.5 | +0.0 |
  |   Code             |          22370 |          22370 |    0 |
+ |   Test             |          10279 |          10483 | +204 |

Code coverage of files in pull request scope (64.4% → 64.4%)

Files Coverage +/-
coverage.go 79.5% 0.0%
http_validator.go 81.5% 0.0%
runner_option.go 37.5% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 0f97e31 into main Apr 30, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-conc branch April 30, 2024 23:43
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant