Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time() ( allow any type ) #928

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix time() ( allow any type ) #928

merged 1 commit into from
May 20, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 20, 2024

ref: #926

@k1LoW k1LoW self-assigned this May 20, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #928 (720ff3a) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,804,799,230 ns/op 3,748,580,794 ns/op -56,218,436 ns/op
Bytes allocated per iteration 1,792,694,760 B/op 1,792,829,000 B/op 134,240 B/op
Allocs per iteration 21,406,207 allocs/op 21,406,408 allocs/op 201 allocs/op
Metadata
main (-) #928 (720ff3a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #928 (720ff3a) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,161,379,468 ns/op 5,376,548,474 ns/op 215,169,006 ns/op
Bytes allocated per iteration 2,952,545,472 B/op 2,951,980,576 B/op -564,896 B/op
Allocs per iteration 29,383,510 allocs/op 29,380,886 allocs/op -2,624 allocs/op
Metadata
main (-) #928 (720ff3a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #928 (720ff3a) +/-
Number of iterations 18 19 1
Nanoseconds per iteration 63,494,276 ns/op 63,314,059 ns/op -180,217 ns/op
Bytes allocated per iteration 60,302,891 B/op 60,286,866 B/op -16,025 B/op
Allocs per iteration 205,776 allocs/op 205,757 allocs/op -19 allocs/op
Metadata
main (-) #928 (720ff3a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (35a5ea7) #928 (720ff3a) +/-
Coverage 64.1% 64.1% -0.0%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 6m13s 5m28s -45s
Details
  |                     | main (35a5ea7) | #928 (720ff3a) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          64.1% |          64.1% | -0.0% |
  |   Files             |             75 |             75 |     0 |
  |   Lines             |           8170 |           8175 |    +5 |
+ |   Covered           |           5234 |           5237 |    +3 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.0 |
  |   Code              |          23528 |          23538 |   +10 |
+ |   Test              |          11166 |          11167 |    +1 |
+ | Test Execution Time |          6m13s |          5m28s |  -45s |

Code coverage of files in pull request scope (100.0% → 88.9%)

Files Coverage +/-
builtin/time.go 88.9% -11.1%

Reported by octocov

@k1LoW k1LoW merged commit c184f12 into main May 20, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-time branch May 20, 2024 02:18
@github-actions github-actions bot mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant