Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serverless-offline + serverless-s3-local support #79

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

kking124
Copy link

PR adds support for serverless-offline https://www.serverless.com/plugins/serverless-offline with serveless-s3-local https://www.serverless.com/plugins/serverless-s3-local

To use, move existing buckets into a buckets field and include an endpoint field in the custom.s3Sync section of serverless.yaml.

PR supports existing serverless.yaml configuration for backwards compatibility.

@k1LoW
Copy link
Owner

k1LoW commented Feb 12, 2021

@kking124 Thank you for your GREAT COMMIT!!

I would like to consider the configuration structure you suggested as a new one for serverless-s3-sync.

However, I don't have the time to develop serverless-s3-sync right now, so I would like to merge this PR first.

@k1LoW k1LoW merged commit 7eaca9c into k1LoW:master Feb 12, 2021
@k1LoW
Copy link
Owner

k1LoW commented Feb 12, 2021

Released as v1.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants