Allow modify model config at decode time for ASR #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow modify model config at decode time for ASR. k2-fsa#1116
csukuangfj
reviewed
Jul 13, 2024
sherpa-onnx/c-api/c-api.h
Outdated
| @@ -491,7 +496,9 @@ SHERPA_ONNX_API void DecodeMultipleOfflineStreams( | |||
| SHERPA_ONNX_API typedef struct SherpaOnnxOfflineRecognizerResult { | |||
| const char *text; | |||
|
|
|||
| // Pointer to continuous memory which holds timestamps | |||
| const char *lang; | |||
There was a problem hiding this comment.
For the newly added member, please add it as the last field.
That is, move line 499 to line 529
Addressing PR comments
csukuangfj
requested changes
Jul 13, 2024
sherpa-onnx/c-api/c-api.cc
Outdated
| @@ -308,8 +308,27 @@ struct SherpaOnnxOfflineStream { | |||
| : impl(std::move(p)) {} | |||
| }; | |||
|
|
|||
| sherpa_onnx::OfflineRecognizerConfig convertConfig( | |||
There was a problem hiding this comment.
Suggested change
| sherpa_onnx::OfflineRecognizerConfig convertConfig( | |
| static sherpa_onnx::OfflineRecognizerConfig convertConfig( |
sherpa-onnx/c-api/c-api.cc
Outdated
|
|
||
| return recognizer; | ||
| void SetSherpaOnnxOfflineRecognizerConfig( |
There was a problem hiding this comment.
Suggested change
| void SetSherpaOnnxOfflineRecognizerConfig( | |
| void SherpaOnnxOfflineRecognizerSetConfig( |
| char *c_lang = new char[lang.size() + 1]; | ||
| std::copy(lang.begin(), lang.end(), c_lang); | ||
| c_lang[lang.size()] = '\0'; | ||
| r->lang = c_lang; |
There was a problem hiding this comment.
Remember to use
delete[] r->lang;
to avoid memory leak.
csukuangfj
reviewed
Jul 13, 2024
Addressing PR comments.
|
@csukuangfj I addressed the comments. Thank you for the suggestions! |
|
Thank you! We will merge it once the CI gets passed. (Don't worry about the failed CI tests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow modify model config at decode time for ASR.
#1116
Also, exposes the language which was recognized by whisper to the calling client in the SherpaOnnxOfflineRecognizerResult.