Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the icon on TTS engine for android #579

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

paolo-caroni
Copy link
Contributor

As promised here at @csukuangfj I have updated the icon logo.

WARNING: to create the xml files I have vectorized the bitmap image provided with the pdf, especially for foreground start from a vectorial image would lead to less space, since that it should be done to the original author or he/she will send me the official .svg.

Since the space problem I have updated only SherpaOnnxTtsEngine icons, not the other on this repo, that I think would be updated too.

About the fastlane directory I will wait untill #569 is resolved.

@csukuangfj
Copy link
Collaborator

Thanks!

Could you post a screenshot about the app after applying this pull request?

@paolo-caroni
Copy link
Contributor Author

paolo-caroni commented Feb 9, 2024

Honestly I have not yet compiled it, it's only an image change, not a code change, you can see the webp image raw directly on the repo, for example here:
https://raw.githubusercontent.com/paolo-caroni/sherpa-onnx/master/android/SherpaOnnxTtsEngine/app/src/main/res/mipmap-xxxhdpi/ic_launcher.webp

If you want in the next days I will compile it (for the first time, but I have seen that is well documented) and then post here a screenshot :)

Edit: I have compiled it and the icon don't change, I wiil understand why and then add a correction commit. I'm really sorry

@paolo-caroni
Copy link
Contributor Author

paolo-caroni commented Feb 13, 2024

Ok, I have corrected it, the problem was that the resolution was too high, too much vectorial points, on android studio I see the previews but on compiling give an error (string too large), sorry.
Here you have the screenshots. I have removed much details from the logo, I would be happy to redone all with the support of the original desiner.
IMG_20240213_194151_968
IMG_20240213_194152_153
IMG_20240213_194151_647

@paolo-caroni
Copy link
Contributor Author

@csukuangfj I'm really sorry that I assumed everything would work just by looking at the preview. I'm sure that you have noticed it and asked me a screenshot because of this.

@csukuangfj
Copy link
Collaborator

Great!

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 92a8fd6 into k2-fsa:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants