-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid picking old helm-delete job #232
Open
w13915984028
wants to merge
2
commits into
k3s-io:master
Choose a base branch
from
w13915984028:fix177
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to do this here, the job patcher already deletes and re-creates the job as necessary, as part of the Apply logic:
helm-controller/pkg/controllers/chart/chart.go
Lines 167 to 173 in 255f905
helm-controller/pkg/controllers/chart/chart.go
Lines 126 to 129 in 255f905
helm-controller/pkg/controllers/chart/chart.go
Lines 237 to 239 in 255f905
Is there some other bit of logic that the patcher needs to capture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the bug is due to
WithOwner(chart).
inhelm-controller/pkg/controllers/chart/chart.go
Line 242 in 255f905
First round of create & delete a HelmChart X
Second round of create & delete a HelmChart X
But
helm-controller/pkg/controllers/chart/chart.go
Line 254 in 255f905
helm-controller/pkg/controllers/chart/chart.go
Line 278 in 255f905
That's the gap in the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we manually create a same namespaced & named
helm-delete
job before deleting a HelmChart, I guess it will also shortcut the HelmChart's real deleting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, the WithOwner stuff uses the owning object's name, namespace, and GVK to track resources across namespaces. As long as the owning HelmChart object shares those same attributes across delete/create cycles it should track it properly. If you run the controller with --debug you should get debug logs from the DesiredSet stuff showing you what it's trying to do - does that shed any light on the situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandond
I add some debug #177 (comment) on Harvester environment, the logs /events can clearly show that, the
generic.ConfigureApplyForObject
is not able to correctly identify the old lefthelm-delete
job.From the debug, it looks essential to remove the old job.
Btw the created
helm-delete
job, has noOwner
field; the apply has a interl owner field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orphaned job, was left per this return
And the normal running path has this call
I will test if
add this call to the above return
works.