-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest install.sh
exits without error message on airgapped nodes
#7247
Comments
@djpbessems I am not able to reproduce with these following steps:
can you make sure that the steps are the same, or am I missing something |
@djpbessems You might try running the script with INSTALL_K3S_SKIP_DOWNLOAD=true INSTALL_K3S_EXEC="server --cluster-init --token <token> --tls-san <ipaddress> --disable local-storage --config /etc/rancher/k3s/config.yaml" sh -x ./install.sh |
I realised I forgot to share that this is happening on an air-gapped system. Since k3s (and kube-vip) needs a default route, I've configured the system with a bogus default route. When I then run the latest version of the install script, it stops with a silent error (last few lines of output when running with
When I then replace the default route with a working gateway, the command succeeds again. So the latest changes make k3s unable to be installed in an air-gapped environment despite the |
@galal-hussein it looks like the change at 027cc18#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44fR500-R504 makes it call out to the GitHub API to retrieve the latest release of the While I do like the idea of having the script call out to get the latest version to suggest, we probably need to make that an optional check with a short timeout, and fall back to a known-good default value. It also shouldn't happen when we're not downloading anything. |
+1 to this issue on CoreOS on versions Full OS-Release for our primary image
We're also seeing a silent failure at the Here's a bunch of debug info. Let me know if you need something additional. Last lines of script with `-x`
curl -s https://api.github.com/repos/k3s-io/k3s-selinux/releases/latest
grep -oP '(?<="browser_download_url": ")[^"]*'
All together now
|
We fell back to the previous version of the script for now, as we need to spin up a cluster for a competition this weekend (new cluster each week). Will look out for the fix on this ticket! Link to previous version of script for anyone looking to do the same: |
Also as a note - the script appears to work as is if exporting the variable Logs from script
|
Not sure if this is realated but I am seeing today that When I SSH'd on to the EC2 instance I had to run the install script by hand a few times before it worked I'm trying to work around it with some retries in my script, but if this is round robin'ing to some old script thats in cache or what not then retry'ing will start failing echo "INSTALLING_K3S" > /home/admin/status
install_k3s() {
echo "installing k3s"
curl -sfL https://get.k3s.io | bash -
sudo chown -R admin:admin /etc/rancher/k3s
echo "finished installing k3s"
}
# Install K3s with 20 retries
for i in {1..20}; do install_k3s && break || sleep 1; done
echo "INSTALLING_ADMISSION_CONTROLLER" > /home/admin/status I might look into #7247 (comment) and see if I can pin to a known working script. |
FWIW I tried pinning to this version and was still experiencing my issue. |
@fieldju sounds like you're having a different issue. Our experienced of it has been completely consistent thus far. |
@fieldju that is unrelated. The K3s channel server is on infrastructure that is occasionally overloaded when Rancher releases chart updates. |
install.sh
exits without error messageinstall.sh
exits without error message on airgapped nodes
I am seeing the same issue. https://github.com/argoproj/argo-workflows/actions/runs/4641097132/jobs/8217213836 Any suggestions? What I did was as usual:
|
@terrytangyuan see my message directly above yours. |
I just pushed up a commit with some changes that I think will help with some if the issues here. I'll test it and make a pull request if this at least resolves the coreos issue. Edit: Note that the boolean on the "testing" check is |
Thanks. Looks like stable is no longer available. I pinned the CI to a specific version. |
I am seeing an error that may have the same root cause, related to using the -P option with grep. I started seeing this on Friday, April 7. The timing of when the error started seems to coincide with the code change referenced earlier in the thread.
|
cc @galal-hussein we should also not expect that any non-posix grep options are available, such as |
Validated on
|
Environmental Info:
K3s Version:
master
-branchNode(s) CPU architecture, OS, and Version:
Ubuntu 20.04 LTS
Cluster Configuration:
N/A
Describe the bug:
When running the latest
install.sh
with below command, it exits right after showing[INFO] Skipping k3s download and verify
without an error message (exit code is not 0 though):Steps To Reproduce:
See above
N/A
Expected behavior:
Installation starts.
Actual behavior:
See above
Additional context / logs:
The
install.sh
from tagv1.26.3+k3s1
still works correctly./kind bug
The text was updated successfully, but these errors were encountered: