Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithSkipMissing to not fail import on missing blobs #10136

Merged
merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Add WithSkipMissing to not fail import on missing blobs.

Fix an issue where archives produced by ctr image export cannot be imported, unless the images are pulled and exported with the --all-platforms flag.

Types of Changes

enhancement

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner May 22, 2024 20:10
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (1d22b69) to head (af470b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10136      +/-   ##
==========================================
- Coverage   47.58%   41.63%   -5.96%     
==========================================
  Files         173      173              
  Lines       14651    14651              
==========================================
- Hits         6972     6100     -872     
- Misses       6348     7385    +1037     
+ Partials     1331     1166     -165     
Flag Coverage Δ
e2etests 36.39% <100.00%> (-9.88%) ⬇️
inttests 19.79% <0.00%> (ø)
unittests 11.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants