-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toleration support to ServiceLB DaemonSet #10687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks! I have one nit, and a question about whether or not there is existing upstream validation code we can reuse.
Can you provide an example of both json and yaml annotation values?
Signed-off-by: Alireza Eskandari <alireza.eskandari@wsd.com>
53471ea
to
01d4714
Compare
Thanks for review. I have updated the code and remove the redundant check. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10687 +/- ##
==========================================
- Coverage 49.64% 39.90% -9.75%
==========================================
Files 179 162 -17
Lines 14955 14333 -622
==========================================
- Hits 7424 5719 -1705
- Misses 6168 7437 +1269
+ Partials 1363 1177 -186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ios17
Proposed Changes
This pull request introduces a new feature that allows ServiceLB to handle Kubernetes tolerations defined in a service's annotations. The changes include:
getTolerations
method, which retrieves and validates tolerations from a service's annotations in JSON or YAML string format.newDaemonSet
method to append the retrieved tolerations to the DaemonSet's pod tolerations.These changes enable users to customize tolerations directly through service annotations, providing greater flexibility in pod scheduling.
Types of Changes
Verification
To verify the changes:
LoadBalancer
type andsvccontroller.k3s.cattle.io/tolerations
annotation containing valid JSON or YAML formatted tolerations list.yaml example:
json example:
Testing
Linked Issues
This PR addresses issue #1988.
User-Facing Change
Further Comments