Traefik v2 integration #2910
Merged
Traefik v2 integration #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwilson
force-pushed
the
traefik-v2
branch
4 times, most recently
from
d0993ee
to
d4f11c7
Compare
erikwilson
force-pushed
the
traefik-v2
branch
from
d4f11c7
to
ae0920e
Compare
dweomer
approved these changes
Feb 18, 2021
brandond
requested changes
Feb 19, 2021
brandond
approved these changes
Feb 24, 2021
K3s upgrade via watch over file change of static file and manifest and triggers helm-controller for change. It seems reasonable to only allow upgrade traefik v1->v2 when there is no existing custom traefik HelmChartConfig in the cluster to avoid any incompatibility. Here also separate the CRDs and put them into a different chart to support CRD upgrade. Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Allow writing static files regardless of the version. Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Logging cleanup Co-authored-by: Brad Davidson <brad@oatmail.org>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Happy path Traefik v2 integration, modified from #2774
Types of Changes
Skip Traefik v2 if Traefik v1 is present
Combine manifests (still deploys 2 helm charts)
Verification
k8s 1.20.2 -> this PR
Linked Issues
#1141
Further Comments
Due to the annotation -> crd nature of Traefik v1 -> v2 we can not upgrade, needs manual migration (see https://github.com/traefik/traefik-migration-tool)