install.sh: initial support for sle-micro #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweomer
force-pushed
the
feat/3188/sle-micro
branch
4 times, most recently
from
4c649b9
to
3dd8eed
Compare
Oats87
approved these changes
Oct 27, 2021
brandond
requested changes
Oct 27, 2021
Support invoking install.sh on SLE Micro with or without SELinux enabled. Same deal for SLES. Additionally, easy-to-invoke assertions, via Vagrant, that the local install.sh works correctly: - tests/install/centos-7 (stand-in for rhel 7) - tests/install/centos-8 (stand-in for rhel 8) - tests/install/opensuse-leap (stand-in for sles) - tests/install/opensuse-microos (stand-in for sle-micro) - tests/install/ubuntu-focal Addresses k3s-io#3188 Addresses k3s-io#3917 Signed-off-by: Jacob Blain Christen <jacob@rancher.com>
dweomer
force-pushed
the
feat/3188/sle-micro
branch
from
3dd8eed
to
0fd49d6
Compare
brandond
approved these changes
Oct 27, 2021
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Support invoking install.sh on SLE Micro with or without SELinux enabled. Same deal for SLES.
Types of Changes
New-ish Feature-like Thing ™️
Verification
Additionally, easy-to-invoke assertions, via Vagrant, to verify that the local install.sh works correctly:
Pre-requisites:
vagrant plugin install vagrant-k3svagrant plugin install vagrant-reloadcdinto one of these directories andvagrant up. A non-zero exit code means that the assertion failed (outbound network connectivity is required for installing packages) whereas an exit code of zero is a win 🎉Linked Issues
Addresses #3188
Addresses #3917
User-Facing Change
Further Comments
Signed-off-by: Jacob Blain Christen jacob@rancher.com