Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: fix path detection for sle-micro #4398

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

AdamMajer
Copy link
Contributor

transactional-update was always under /usr/sbin for SLE Micro

Proposed Changes

Fix the path used to detect presence of transactional-update system

Types of Changes

Correcting PR: #4331

Verification

I've run install.sh on SLE Micro OS 5.1 image

Linked Issues

PR: #4331

User-Facing Change


Further Comments

openSUSE MicroOS is based on Tumbleweed which has already replaced /bin with just /usr/bin and /bin is symlinked to /usr/bin which could have resulted in the this script working on openSUSE. SLE doesn't have plans to do the same filesystem changes.

@AdamMajer AdamMajer requested a review from a team as a code owner November 4, 2021 13:41
@sysrich
Copy link
Contributor

sysrich commented Nov 4, 2021

This is not only needed for SLE-Micro, but openSUSE MicroOS also
+1 from me

transactional-update was always under /usr/sbin.

Signed-off-by: Adam Majer <amajer@suse.de>
@dweomer
Copy link
Contributor

dweomer commented Nov 5, 2021

Addresses #4402

@dweomer dweomer merged commit f1d6e9b into k3s-io:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants