[Release-1.21] Removed warning about skipping flags #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made parser able to skip over subcommands * Edge case coverage, reworked regex with groups Signed-off-by: Derek Nola <derek.nola@suse.com>
…y used with k3s server. (k3s-io#4464) * Enabled skipping of unknown flags from config in parser * Added new unit test, expanded existing Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
briandowns
approved these changes
Nov 15, 2021
dweomer
approved these changes
Nov 15, 2021
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
QA showed that the warning was confusing and unnecessary and could potentially reveal secret information.
Types of Changes
Bugfix
Verification
Same as #4464, but warning should not show value of the flag.
Linked Issues
#4481
User-Facing Change
Further Comments