Fix issue with long-running apiserver endpoints watch #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ListWatch helpers to retry when the watch channel is closed. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix_apiserver_endpoint_watch
branch
from
5f5254b
to
33340cc
Compare
manuelbuil
approved these changes
Apr 21, 2022
dereknola
approved these changes
Apr 21, 2022
briandowns
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use ListWatch helpers to retry when the watch channel is closed.
Types of Changes
bugfix
Verification
Leave k3s running for ~30 minutes, note no spamming errors:
Linked Issues
Failed to watch apiserver addresseserror after ~30 minutes of uptime #5482User-Facing Change
Further Comments