Fix deletion of svclb DaemonSet when Service is deleted #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
approved these changes
Jul 8, 2022
brandond
force-pushed
the
fix_svclb_delete
branch
from
d410d90
to
f995fc1
Compare
briandowns
approved these changes
Jul 8, 2022
brandond
force-pushed
the
fix_svclb_delete
branch
3 times, most recently
from
9d70c12
to
0f96487
Compare
87e1806 removed the OwnerReferences field from the DaemonSet, which makes sense since the Service may now be in a different namespace than the DaemonSet and cross-namespace owner references are not supported. Unfortunately, we were relying on garbage collection to delete the DameonSet, so this started leaving orphaned DaemonSets when Services were deleted. We don't want to add an a Service OnRemove handler, since this will add finalizers to all Services, not just LoadBalancers services, causing conformance tests to fail. Instead, manage our own finalizers, and restore the DaemonSet removal Event that was removed by the same commit. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
87e1806 removed the OwnerReferences
field from the DaemonSet, which makes sense since the Service may now be
in a different namespace than the DaemonSet and cross-namespace owner
references are not supported. Unfortunately, we were relying on
garbage collection to delete the DameonSet, so this started leaving
orphaned DaemonSets when Services were deleted.
We don't want to add an a Service OnRemove handler, since this will add
finalizers to all Services, not just LoadBalancers services, causing
conformance tests to fail. Instead, manage our own finalizers, and
restore the DaemonSet removal Event that was removed by the same commit.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments