Remove deprecated nodeSelector label beta.kubernetes.io/os #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Don't forget to sign your commit for DCO. Also, you need to update the bindata when modifying the manifests. You can do this by running |
Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com>
Signed-off-by: Dan Mills <evilhamsterman@gmail.com>
|
All done. |
brandond
approved these changes
Feb 16, 2023
Codecov ReportBase: 9.51% // Head: 9.51% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #6970 +/- ##
======================================
Coverage 9.51% 9.51%
======================================
Files 146 146
Lines 10757 10757
======================================
Hits 1024 1024
Misses 9515 9515
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dereknola
approved these changes
Feb 16, 2023
|
Thanks again for the contribution! |
This was referenced Mar 20, 2023
galal-hussein
pushed a commit
to galal-hussein/k3s
that referenced
this pull request
Mar 20, 2023
* Remove deprecated nodeSelector label beta.kubernetes.io/os Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com>
galal-hussein
pushed a commit
to galal-hussein/k3s
that referenced
this pull request
Mar 20, 2023
* Remove deprecated nodeSelector label beta.kubernetes.io/os Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com> Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
pushed a commit
to galal-hussein/k3s
that referenced
this pull request
Mar 20, 2023
* Remove deprecated nodeSelector label beta.kubernetes.io/os Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com> Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein
added a commit
that referenced
this pull request
Apr 4, 2023
…7122) * Remove deprecated nodeSelector label beta.kubernetes.io/os Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com> Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> Co-authored-by: Daniel Mills <evilhamsterman@users.noreply.github.com>
galal-hussein
added a commit
that referenced
this pull request
Apr 4, 2023
…7121) * Remove deprecated nodeSelector label beta.kubernetes.io/os Problem: The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon Solution: Change the nodeSelector to remove the beta Signed-off-by: Dan Mills <evilhamsterman@gmail.com> Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com> Co-authored-by: Daniel Mills <evilhamsterman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon
Solution:
Change the nodeSelector to remove the beta
Proposed Changes
Remove the beta from the nodeSelector in the CoreDNS manifest since it's been deprecated since 1.14
Types of Changes
Bugfix
Verification
Redeploy the CoreDNS manifest with the new nodeSelector
Testing
Linked Issues
beta.kubernetes.io/os#6977User-Facing Change
Further Comments