Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.25] Remove deprecated nodeSelector label beta.kubernetes.io/os (#6970) #7121

Merged
merged 1 commit into from Apr 4, 2023

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented Mar 20, 2023

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@galal-hussein galal-hussein requested a review from a team as a code owner March 20, 2023 21:46
* Remove deprecated nodeSelector label beta.kubernetes.io/os

Problem:
The nodeSelector label beta.kubernetes.io/os in the CoreDNS deployment was deprecated in 1.14 and will likely be removed soon

Solution:
Change the nodeSelector to remove the beta

Signed-off-by: Dan Mills <evilhamsterman@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein force-pushed the backport_6970 branch 2 times, most recently from e345c1a to e8a82bc Compare March 20, 2023 21:54
@galal-hussein galal-hussein changed the title Backport 6970 [Release-1.25] Remove deprecated nodeSelector label beta.kubernetes.io/os (#6970) Mar 20, 2023
@galal-hussein galal-hussein merged commit c25f611 into k3s-io:release-1.25 Apr 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants